Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: release binaries #105

Merged
merged 2 commits into from
Mar 19, 2025
Merged

feat: release binaries #105

merged 2 commits into from
Mar 19, 2025

Conversation

marco-ippolito
Copy link
Member

No description provided.

@marco-ippolito marco-ippolito force-pushed the pack-some-bins branch 11 times, most recently from 9878c46 to 52a82e6 Compare March 18, 2025 11:17
@edezekiel
Copy link

edezekiel commented Mar 18, 2025 •
edited
Loading

I think the command oclif pack tarballs -t <platform-targets[]> supports targeting multiple platforms without needing multiple package.jsons.[1] This PR just uses oclif pack <target>.

The documentation isn't super clear on how the tarballs command works though.[2] For example it's unclear whether you wind up with multiple node bins in a single package.
[1]https://github.com/oclif/oclif/blob/main/src%2Fcommands%2Fpack%2Ftarballs.ts
[2]https://oclif.io/docs/releasing#standalone-tarballs

@marco-ippolito marco-ippolito force-pushed the pack-some-bins branch 12 times, most recently from 326bb64 to 70b220c Compare March 18, 2025 15:05
@marco-ippolito marco-ippolito changed the base branch from dtw/oclif-rewrite-again to dev March 18, 2025 15:05
edezekiel
edezekiel reviewed Mar 18, 2025
View reviewed changes
README.md
@@ -17,7 +16,7 @@ $ npm install -g @herodevs/cli
$ hd COMMAND
running command...
$ hd (--version)
@herodevs/cli/2.0.0 darwin-arm64 node-v22.14.0
@herodevs/cli/2.0.0 darwin-arm64 node-v22.13.0
Copy link

@edezekiel edezekiel Mar 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: should this be @herodevs/cli/1.0.0-beta This comment also applies to all other instances of @herodevs/cli/2.0.0 (and "version": "2.0.0") in this PR

@edezekiel
chore: fix package versions and add token (#107)
6f17028 
* chore: set draft to true while still wip

* chore: fix package versions

* chore: add github token to publish step

* chore: debug publish ci step

* chore: add more debugging

* chore: revert to hd-* for upload artifact

* chore: try different token for npm publish

* chore: add missing registry-url

* chore: moar debug

* chore: add missing --no-xz to win build

* chore: fix files glob in final step
@marco-ippolito marco-ippolito merged commit e53c5a6 into dev Mar 19, 2025
5 checks passed
@marco-ippolito marco-ippolito deleted the pack-some-bins branch March 19, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edezekiel edezekiel edezekiel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marco-ippolito @edezekiel